Attempt to patch the directory list when possible#763
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark Index (community)
Details
| Benchmark suite | Current: 5e0d2e3 | Previous: 209c2fa | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
21 ms |
21 ms |
1 |
Add one schema (100 existing) |
27 ms |
36 ms |
0.75 |
Add one schema (1000 existing) |
84 ms |
111 ms |
0.76 |
Add one schema (10000 existing) |
694 ms |
947 ms |
0.73 |
Update one schema (1 existing) |
19 ms |
19 ms |
1 |
Update one schema (101 existing) |
28 ms |
29 ms |
0.97 |
Update one schema (1001 existing) |
85 ms |
114 ms |
0.75 |
Update one schema (10001 existing) |
631 ms |
908 ms |
0.69 |
Cached rebuild (1 existing) |
11 ms |
10 ms |
1.10 |
Cached rebuild (101 existing) |
12 ms |
14 ms |
0.86 |
Cached rebuild (1001 existing) |
26 ms |
26 ms |
1 |
Cached rebuild (10001 existing) |
187 ms |
194 ms |
0.96 |
Index 100 schemas |
122 ms |
142 ms |
0.86 |
Index 1000 schemas |
1061 ms |
1090 ms |
0.97 |
Index 10000 schemas |
14182 ms |
14634 ms |
0.97 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Benchmark Index (enterprise)
Details
| Benchmark suite | Current: 5e0d2e3 | Previous: 50e3005 | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
22 ms |
22 ms |
1 |
Add one schema (100 existing) |
27 ms |
29 ms |
0.93 |
Add one schema (1000 existing) |
81 ms |
102 ms |
0.79 |
Add one schema (10000 existing) |
707 ms |
922 ms |
0.77 |
Update one schema (1 existing) |
20 ms |
20 ms |
1 |
Update one schema (101 existing) |
26 ms |
30 ms |
0.87 |
Update one schema (1001 existing) |
80 ms |
101 ms |
0.79 |
Update one schema (10001 existing) |
603 ms |
837 ms |
0.72 |
Cached rebuild (1 existing) |
11 ms |
12 ms |
0.92 |
Cached rebuild (101 existing) |
13 ms |
13 ms |
1 |
Cached rebuild (1001 existing) |
27 ms |
28 ms |
0.96 |
Cached rebuild (10001 existing) |
189 ms |
189 ms |
1 |
Index 100 schemas |
121 ms |
121 ms |
1 |
Index 1000 schemas |
1080 ms |
1073 ms |
1.01 |
Index 10000 schemas |
14574 ms |
14167 ms |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
🤖 Augment PR SummarySummary: This PR makes explorer directory listing generation opportunistically reuse ("patch") entries from a previously-generated listing. Changes:
Technical Notes: The patching path is gated on the destination file already existing and skips reuse for dependencies present in the current build overlay. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
jviotti
force-pushed
the
delta-list-generation
branch
from
361a96b to
5e0d2e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com